Repository navigation
Alternative locator syntax - #909
Merged
aaltat merged 7 commits intoSep 21, 2017
Merged
Conversation
…k#908. Still need to decided how to handle locators which just happen to have `:` in them like `foo:bar`. With the current implementation they fail with a ValueError becaue `foo` is not a valid locator prefix. Could also change the logic to handle this so that `:` and `=` are separators *only* if the part before is a valid prefix. Docs are missing too.
Didn't notice earlier that _parse_locator was already tested. Decided to remove old tests because the ones I added are a little simpler due to the use of `_verify_parse_locator` helper. Added few more tests to cover everything the old tests covered.
Earlier `foo=bar` caused ValueError if `foo` wasn't a valid locator. Now this is same as `default=foo=bar`. Main motivation to the change is avoiding bwic problems now when we are adding support for locators using`foo:bar` syntax (robotframework#908).
Also tabs -> spaces in edited html file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #908.
Docs missing but code and tests ready for review. We may still want to think about error reporting when a locator doesn't match any element, though.